-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support for gateway api for safer cluster variants #1523
feat!: support for gateway api for safer cluster variants #1523
Conversation
Re-run the checks |
Can't, unfortunately, I don't think I have the necessary permissions |
I have re-triggered it for you. |
Still no luck it seems :( |
Thanks for the contribution @lauraseidler! - I suspect the test failure is related to #1525 |
Could be - it's really hard to figure out without having access to the builds. I guess I'll wait for the fix, then rebase and see if it works then. |
@lauraseidler sorry that I missed to add this feature to the safer cluster module as well in the initial PR |
Thanks @lauraseidler for the contribution. LGTM overall. Just a minor comment here. Could you please also update the modules/safer-cluster/variables.tf to pin the Google provider version >= 4.47.0 |
@ericyz the google provider version is currently not in there at all - do you want me to add it? I think since the safer cluster variants just use the beta private cluster module with some variables set to defaults, it's not necessary. However, I see that the |
737fbb1
to
d09a7d4
Compare
Yeah I actually think this would break if released as is, as the gateway API support is implemented for the beta clusters, but the provider constraint is not there - I pushed the increase, so probably it's a good idea to merge this before #1512. |
Thanks @lauraseidler . Yes, it implicitly uses other modules. That's all good |
LGTM and will approve once the CI passed |
@lauraseidler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @lauraseidler!
Follow up to #1510