Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update variable validation description #1518

Merged
merged 1 commit into from
Jan 4, 2023
Merged

fix: Update variable validation description #1518

merged 1 commit into from
Jan 4, 2023

Conversation

Tolsee
Copy link
Contributor

@Tolsee Tolsee commented Jan 4, 2023

  • Update description to match the validation rule

Fixes: #1438

@Tolsee Tolsee requested review from a team and Jberlinsky as code owners January 4, 2023 16:15
@comment-bot-dev
Copy link

@Tolsee
Thanks for the PR! 🚀
✅ Lint checks have passed.

apeabody
apeabody approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Tolsee!

@apeabody apeabody changed the title bug: Update variable validation description fix: Update variable validation description Jan 4, 2023
@apeabody apeabody merged commit d985879 into terraform-google-modules:master Jan 4, 2023
@release-please release-please bot mentioned this pull request Jan 4, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@Tolsee
fix: Update variable validation description (terraform-google-modules…
283e089 
…#1518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node metadata validation error message does not contain all supported options
3 participants
@Tolsee @comment-bot-dev @apeabody