Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: promote gce_pd_csi_driver to GA #1509

Conversation

mnahkies
Copy link
Contributor

Promotes the gce_pd_csi_driver variable to GA, as it has been GA in GKE since:

Notes

  • ⚠️ Enables by default to match the behavior of create cluster when it is omitted
    • I think this is safe and desirable, but let me know if not. People can override it when upgrading the module if they wish to leave it disabled on older clusters.
  • ✔️ versions.tf.tmp doesn't need updating, as the underlying config was made GA in an earlier version than already specified

Questions

  • Should I update the changelog?

@mnahkies mnahkies requested review from a team and Jberlinsky as code owners December 22, 2022 11:23
@bharathkkb bharathkkb changed the title feat: promote gce_pd_csi_driver to GA feat!: promote gce_pd_csi_driver to GA Dec 28, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mnahkies
Agreed regarding default and can we add a small upgrade guide to call this out showing how users can set this to false similar to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v24.0.md#master_global_access_enabled-in-ga-private-cluster-module

@mnahkies
Copy link
Contributor Author

Thanks for the PR @mnahkies Agreed regarding default and can we add a small upgrade guide to call this out showing how users can set this to false similar to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v24.0.md#master_global_access_enabled-in-ga-private-cluster-module

Thanks for the review @bharathkkb - I've synced in changes from master and added an upgrade guide.

I took the liberty of including a note about #1495 as I noticed there was no guide for it's changes that are scheduled for release in #1512 - though please let me know if that should be added elsewhere / omitted.

@comment-bot-dev
Copy link

@mnahkies
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mnahkies!

@bharathkkb bharathkkb merged commit ac062f8 into terraform-google-modules:master Dec 29, 2022
@mnahkies mnahkies deleted the mn/feat/promote-pd-csi-driver-ga branch January 3, 2023 09:59
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants