Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Promote managed_prometheus to GA #1505

Merged
merged 14 commits into from
Jan 6, 2023
Merged

feat!: Promote managed_prometheus to GA #1505

merged 14 commits into from
Jan 6, 2023

Conversation

IIBenII
Copy link
Contributor

@IIBenII IIBenII commented Dec 19, 2022

The managed_prometheus option is now GA since the version 4.46.0

@IIBenII IIBenII requested review from a team and Jberlinsky as code owners December 19, 2022 17:20
@IIBenII
Copy link
Contributor Author

IIBenII commented Dec 20, 2022

@Jberlinsky Can I have more detail about the failing tests? Thanks

@ericyz
Copy link
Collaborator

ericyz commented Dec 28, 2022

Triggering test again

@bharathkkb bharathkkb changed the title feat: Promote managed_prometheus to GA feat!: Promote managed_prometheus to GA Dec 28, 2022
@IIBenII IIBenII force-pushed the promote_prometheus_ga branch from 8786814 to 0817334 Compare December 29, 2022 09:57
@IIBenII
Copy link
Contributor Author

IIBenII commented Dec 29, 2022

@ericyz Tests still fail, can you give me more informations about the error? Sadly I can't run tests on my side due to organisation constraint about public cluster 😢

@ericyz
Copy link
Collaborator

ericyz commented Dec 29, 2022

@IIBenII - The test passed. Could you please resolve the conflict? Thanks

@IIBenII
Copy link
Contributor Author

IIBenII commented Dec 30, 2022

@ericyz done

ericyz
ericyz requested changes Jan 3, 2023
View reviewed changes
autogen/main/main.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Show resolved Hide resolved
@IIBenII IIBenII force-pushed the promote_prometheus_ga branch from 791421b to 2c649a8 Compare January 3, 2023 14:48
@IIBenII
Copy link
Contributor Author

IIBenII commented Jan 3, 2023

@ericyz Thanks for all your feedbacks. According to this documentation https://cloud.google.com/kubernetes-engine/docs/resources/autopilot-standard-feature-comparison I also updated how we handle logging/monitoring for autopilot clusters.

ericyz
ericyz requested changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM overall, please address the comments and resolve the conflicts

autogen/main/main.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
modules/beta-private-cluster-update-variant/README.md Show resolved Hide resolved
@IIBenII IIBenII force-pushed the promote_prometheus_ga branch from 08009af to 4c38b35 Compare January 4, 2023 11:18
@IIBenII IIBenII force-pushed the promote_prometheus_ga branch from 3d236ba to f097554 Compare January 4, 2023 14:01
@IIBenII IIBenII force-pushed the promote_prometheus_ga branch 2 times, most recently from 5ed1ebe to a05430b Compare January 4, 2023 16:17
@IIBenII
Copy link
Contributor Author

IIBenII commented Jan 4, 2023

@ericyz I cleaned the code and took your feedbacks, thanks a lot

ericyz
ericyz requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. LGTM, with minor improvement for house-keeping formatting.

autogen/main/main.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Show resolved Hide resolved
IIBenII
IIBenII commented Jan 5, 2023
View reviewed changes
Copy link
Contributor Author

@IIBenII IIBenII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericyz updated

autogen/main/cluster.tf.tmpl Show resolved Hide resolved
@comment-bot-dev
Copy link

@IIBenII
Thanks for the PR! 🚀
✅ Lint checks have passed.

@ericyz
Copy link
Collaborator

ericyz commented Jan 6, 2023

Re-trigger the checks

ericyz
ericyz reviewed Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and will approve once all checks are passed

@ericyz ericyz self-requested a review January 6, 2023 01:05
@bharathkkb bharathkkb merged commit 9c77c6c into terraform-google-modules:master Jan 6, 2023
@release-please release-please bot mentioned this pull request Jan 6, 2023
Merged
@IIBenII IIBenII mentioned this pull request Jan 17, 2023
Closed
@IIBenII IIBenII deleted the promote_prometheus_ga branch January 17, 2023 14:29
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@IIBenII @ericyz
feat!: Promote managed_prometheus to GA (terraform-google-modules#1505)
f5770bd 
Co-authored-by: Eric Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@ericyz ericyz ericyz approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IIBenII @ericyz @comment-bot-dev @bharathkkb