-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Set the provided SA when creating autopilot clusters #1495
feat!: Set the provided SA when creating autopilot clusters #1495
Conversation
If I read the log correctly, the failures reported in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/1495/checks?check_run_id=9992487427 don't seem too related to this PR, but rather to a checksum mismatch when downloading providers/plugins. |
Ah, so now the build may be failing for that yet missing server-side fix. |
It appears to be the case. This is an extract from the Terraform
|
Ah, I was wrongly setting |
Ok, now I think I'm getting the server-side error on a resource update:
I was able to create it anew tho. |
Hi @ferrarimarco! Thank you for working on this. is there a GitHub issue or PR I can watch to track the server side fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ferrarimarco.
I pushed a few changes as we are switching to a new test framework. Looks like this will be a breaking change as the conflict on the field was removed in 4.44+.
@CaliWee hi! I don't think there is a PR or issue to follow. @bharathkkb Thanks for reviewing and for the changes! Update: Yes, in 4.44+. I forgot to update the provider version constraint, but I see you did it. Thanks! |
@ferrarimarco |
…m-google-modules#1495) Co-authored-by: Bharath KKB <[email protected]>
Fixes #1488
Hi folks!
In this PR, I'm trying to address the above issue, although I think the necessary server-side fix is still being rolled out.
Hopefully I got the autogen bits right :)