feat: add all pod_ranges to cluster firewall rules and add missing shadow rules #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splichy
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
splichy
force-pushed
the
feat/firewall_disco_pod_ranges
branch
from
3db1497 to
37bfd15
Compare
ericyz
approved these changes
Dec 6, 2022
splichy
changed the title
splichy
force-pushed
the
feat/firewall_disco_pod_ranges
branch
from
938db8a to
28fab3d
Compare
|
Hi, I have added |
|
@splichy |
bharathkkb
approved these changes
Dec 30, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…adow rules (terraform-google-modules#1480) Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewall rules now include also discontinuous POD IP ranges, previously only cluster-wide pod_range was used for -intra-cluster-egress & -all firewall rules.
Also adding missing(& undocumented) shadow firewall rules (inkubelet, exkubelet)- GKE itself creates incomplete rules, so shadow rules can be used as a quick workaround when someone using discontinuous pod ranges.