feat!: cost_management_config is out of beta now #1470
Conversation
zmaupin
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Thanks for the PR @zmaupin
Looks like this was moved to GA in 4.42. Could you bump the min provider versions in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl
and also update the upgrade guide https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v24.0.md#minimum-google-provider-versions to include this in the latest breaking release #1447
bharathkkb
changed the title
zmaupin
force-pushed
the
feat/zmaupin/enable_cost_management_config
branch
from
a11fc2d to
b268a1d
Compare
|
@bharathkkb Thanks for looking! I have updated the two files you asked me to change. |
move the config outside the logic of beta only
zmaupin
force-pushed
the
feat/zmaupin/enable_cost_management_config
branch
from
b268a1d to
8fcccde
Compare
|
@zmaupin |
…dules#1470) feat: cost_management_config is out of beta now move the config outside the logic of beta only Co-authored-by: Zackary Maupin <[email protected]>
move the config outside the logic of beta only