Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating Membership ID when greater than 63 character #1429

Conversation

akshaybathija-github
Copy link
Contributor

Modifying the Cluster Membership ID to be truncated in case of >63 character based on API limits

API Limit Reference : https://cloud.google.com/anthos/fleet-management/docs/reference/rest/v1/projects.locations.memberships

Earlier the Formula for Calculation was : ${var.project_id}-${var.location}-${var.cluster_name}
Now in case this exceed 63 character it will trim the ending to fit 63 characters

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @akshaybathija-github

modules/fleet-membership/main.tf Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@akshaybathija-github
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 0c5660d into terraform-google-modules:master Oct 19, 2022
@akshaybathija-github akshaybathija-github deleted the bug/acm-fleet-membership-bug branch November 28, 2022 03:52
@akshaybathija-github akshaybathija-github restored the bug/acm-fleet-membership-bug branch November 28, 2022 03:52
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…raform-google-modules#1429)

* Truncating Membership ID when greater than 63 character

* Correcting Linting

* Modifying If Logic and Adding Trim Suffix

Co-authored-by: Akshay Bathija <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants