-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nodepool autoscaling vars avail in GKE 1.24.1 #1415
feat: add nodepool autoscaling vars avail in GKE 1.24.1 #1415
Conversation
Any guidance on this as the new flags require a GKE version (1.24.1+) and not a specific provider version? |
Hi @jmymy - I haven't tested/tried, but you might be able to parse the kubernetes version and |
But we wouldnt know that version at cluster create time, only the release channel? Still thinking through this |
I guess we could do something like the following, but seems like a lot of logic and work to do for something that will be gone in a few months....
I would assume the API still takes these values, but just doesnt do anything if the cluster isnt on this version? need to dig in api spec. |
Hi @jmymy - I seem to recall that |
cloudbuild can now send logs along with the github status checks so we can see them here. Dont know if thats something yall can enable @bharathkkb @Jberlinsky |
@apeabody so the issue i'm hitting is that i cant do a compare on versions like i can in a provider block
|
Thanks @jmymy - I just re-triggered the CI. Where you able to confirm the API just ignores the values with earlier GKE versions? If that is true, it's probably OK, but we should note with a comment in the files to avoid confusion. |
@apeabody i went the easier route and just tried to do it instead lol |
Thanks @jmymy! - I was guessing that might be the result. My current suggestion would be two dynamic blocks (pre/post GKE 1.24.1) and enable the desired one either on (ideally) the GKE version, or at least a boolean with the default as the original behavior. @bharathkkb - Rather than reinventing the wheel, do you happen to know if we have an existing example of a semver comparison (>=) function? |
@bharathkkb all set and updated |
Thanks @bharathkkb! Thanks @jmymy! - I just re-triggered the CI as it might be a transient error. |
@jmymy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmymy!
No description provided.