feat!: Adding Support for Cost Allocation Feature in Beta #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaybathija-github
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
bharathkkb
requested changes
Sep 27, 2022
There was a problem hiding this comment.
Thanks for the PR @akshaybathija-github
This is a breaking change since we will also have to bump the min provider versions to 4.35.
bharathkkb
changed the title
|
Apologies for the bump but it seems all changes have been addressed, any chance we can merge this one in now? @bharathkkb |
|
@Dev25 Yes! We were holding to release a minor version. I will merge this soon. |
|
@akshaybathija-github |
bharathkkb
approved these changes
Nov 2, 2022
akshaybathija-github
deleted the
enhancement/support_for_cost_allocation
branch
akshaybathija-github
restored the
enhancement/support_for_cost_allocation
branch
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…google-modules#1413) * Adding Support for Cost Allocation Feature in Beta * Making Changes to make the module Dynamic * Bumping Min Provider Version Co-authored-by: Akshay Bathija <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for adding Support fort Cost Allocation in Beta Modules, Issue #1392