Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow configuring cluster_autoscaling for safer cluster variants #1407

Conversation

samschlegel
Copy link
Contributor

Does what it says on the tin 😄

max_memory_gb = number
gpu_resources = list(object({ resource_type = string, minimum = number, maximum = number }))
})
default = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love that this is duplicated from the underlying beta cluster, but making it nullable and defaulting to null feels like it hides defaults too much

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we may look at rearchitecting some of these objects with optionals in the future now that 1.3 supports it.

@samschlegel
Copy link
Contributor Author

I also couldn't get make build running on my local because of some strange Docker error that I don't particularly care to hack around if possible 😂 moby/moby#43576

@comment-bot-dev
Copy link

@samschlegel
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @samschlegel

@bharathkkb bharathkkb merged commit a661eea into terraform-google-modules:master Sep 22, 2022
@jawnsy
Copy link

jawnsy commented Oct 8, 2022

@samschlegel FYI in the referenced bug, looks like it's an issue with docker running in rootless mode -- I've run into the same thing when running docker under sysbox, which is also using user namespacing to run rootlessly.

I was able to run all the tools normally using podman in the default rootless mode (I'm running on macOS, so it's inside a VM)

moby/moby#43576 (comment)

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
terraform-google-modules#1407)

* feat: Allow configuring cluster_autoscaling for safer cluster variants

* regen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants