-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow configuring cluster_autoscaling for safer cluster variants #1407
feat: Allow configuring cluster_autoscaling for safer cluster variants #1407
Conversation
max_memory_gb = number | ||
gpu_resources = list(object({ resource_type = string, minimum = number, maximum = number })) | ||
}) | ||
default = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that this is duplicated from the underlying beta cluster, but making it nullable and defaulting to null feels like it hides defaults too much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we may look at rearchitecting some of these objects with optionals in the future now that 1.3 supports it.
I also couldn't get |
@samschlegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @samschlegel
@samschlegel FYI in the referenced bug, looks like it's an issue with docker running in rootless mode -- I've run into the same thing when running docker under sysbox, which is also using user namespacing to run rootlessly. I was able to run all the tools normally using podman in the default rootless mode (I'm running on macOS, so it's inside a VM) |
terraform-google-modules#1407) * feat: Allow configuring cluster_autoscaling for safer cluster variants * regen
Does what it says on the tin 😄