feat:adds placement policy argument to the beta modules #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
g-awmalik
force-pushed
the
feat/add-placement-pol
branch
from
b36286b to
122bcd0
Compare
|
@bharathkkb - can you take a look? I've tested this locally and works fine. What do you think about doing an example for this? Seems like overkill to me. Thoughts? |
|
@g-awmalik agreed we don't need a dedicated example but can we add to an existing example so we can assert it via an existing test. |
bharathkkb
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Let's also add to the nodepool vars list https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/README.md?plain=1#L186
|
@g-awmalik |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1379