Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable PoCo referential_rules for ACM #1373

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Aug 24, 2022

Fixes #1369

@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody
Copy link
Collaborator Author

@bharathkkb Let me know if you would prefer using a new variable to control, for now starting as highly opinionated.

@apeabody apeabody marked this pull request as ready for review August 25, 2022 15:41
@apeabody apeabody requested review from a team, Jberlinsky and bharathkkb as code owners August 25, 2022 15:41
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody! We can move to var later if there is a request.

@apeabody apeabody merged commit b9287de into master Aug 25, 2022
@apeabody apeabody deleted the apeabody-patch-1 branch August 25, 2022 23:39
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACM submodule missing variable
4 participants