feat: add module_depends_on to workload-identity #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #1342 |
apeabody
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
bharathkkb
approved these changes
Aug 3, 2022
|
Also @apeabody I believe terraform-google-modules/terraform-google-gcloud#82 is for supporting the native |
Thanks @bharathkkb - Yes, this and #1323 were for an add-on later in the thread terraform-google-modules/terraform-google-gcloud#82 (comment). I'll change the PR comment to leave the overall issue open. |
|
Holding for discussion on terraform-google-modules/terraform-google-gcloud#123 |
Co-authored-by: Bharath KKB <[email protected]>
|
Enhanced docs per terraform-google-modules/terraform-google-gcloud#123 |
|
@apeabody |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…dules#1341) Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per terraform-google-modules/terraform-google-gcloud#82