-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ravindrafix/added snat #1336
Ravindrafix/added snat #1336
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This change will need to be made in
terraform-google-kubernetes-engine/autogen/main/cluster.tf.tmpl
Lines 67 to 70 in dc1de85
{% if beta_cluster %} | |
default_snat_status { | |
disabled = var.disable_default_snat | |
} |
HI @bharathkkb , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravindrasinghh Can you also run make build
to regenerate.
terraform-google-kubernetes-engine/autogen/main/variables.tf.tmpl
Lines 478 to 482 in bfb5954
variable "disable_default_snat" { | |
type = bool | |
description = "Whether to disable the default SNAT to support the private use of public IP addresses" | |
default = false | |
} |
should also be moved out of the conditional
@ravindrasinghh |
@bharathkkb |
…ules#1336) * fix: added snat code * fix: updated readme * fix: added snat variable * fix: whitespaces * fix readmebuild * fix: removed conditional beta code * removed beta variable * fix readme Co-authored-by: Andrew Peabody <[email protected]>
No description provided.