Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ravindrafix/added snat #1336

Conversation

ravindrasinghh
Copy link
Contributor

No description provided.

@ravindrasinghh ravindrasinghh requested review from a team, Jberlinsky and bharathkkb as code owners July 27, 2022 07:22
@google-cla
Copy link

google-cla bot commented Jul 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This change will need to be made in

{% if beta_cluster %}
default_snat_status {
disabled = var.disable_default_snat
}
removing the conditional for beta.

@ravindrasinghh
Copy link
Contributor Author

HI @bharathkkb ,
Thanks for reply, Code has been updated as per the suggested.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravindrasinghh Can you also run make build to regenerate.

variable "disable_default_snat" {
type = bool
description = "Whether to disable the default SNAT to support the private use of public IP addresses"
default = false
}

should also be moved out of the conditional

@comment-bot-dev
Copy link

@ravindrasinghh
Thanks for the PR! 🚀
✅ Lint checks have passed.

@ravindrasinghh
Copy link
Contributor Author

@bharathkkb
Re ran the make build command, as per the instruction.

@bharathkkb bharathkkb merged commit a8ea7c7 into terraform-google-modules:master Jul 29, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…ules#1336)

* fix: added snat code

* fix: updated readme

* fix: added snat variable

* fix: whitespaces

* fix readmebuild

* fix: removed conditional beta code

* removed beta variable

* fix readme

Co-authored-by: Andrew Peabody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants