Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: promote notification config & dns to ga #1327

Merged

Conversation

ericyz
Copy link
Collaborator

@ericyz ericyz commented Jul 19, 2022

No description provided.

@ericyz ericyz requested review from a team, Jberlinsky and bharathkkb as code owners July 19, 2022 23:39
@ericyz
Copy link
Collaborator Author

ericyz commented Jul 20, 2022

Please review at your convenience. Much appreaciated!

@bharathkkb bharathkkb changed the title feat: support notification config & dns in ga feat!: promote notification config & dns to ga Jul 23, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ericyz
We will add this to our next breaking release since there is a provider bump.

@ericyz
Copy link
Collaborator Author

ericyz commented Aug 8, 2022

rebase master and resolve the conflicts

…oogle-kubernetes-engine into feat/gke_notification
@ericyz ericyz force-pushed the feat/gke_notification branch from c3b1e21 to f5c9703 Compare August 8, 2022 06:15
@comment-bot-dev
Copy link

@ericyz
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 47b5ff6 into terraform-google-modules:master Aug 9, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…les#1327)

* feat: support notification config &dns in ga

* feat: support notification config &dns in ga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants