Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asm kubectl internal endpoint #1219

Conversation

f4tal-err0r
Copy link
Contributor

When running terraform deployments of ASM from inside a GCP VPC there is currently no way to specify an internal endpoint for the underlying kubectl commands to execute. This variable will expose that option.

@f4tal-err0r f4tal-err0r requested review from a team, Jberlinsky and bharathkkb as code owners April 12, 2022 23:30
@google-cla
Copy link

google-cla bot commented Apr 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@f4tal-err0r f4tal-err0r force-pushed the asm-kubectl-internal-endpoint branch from 9e9bcff to 538c2fd Compare April 12, 2022 23:41
@comment-bot-dev
Copy link

comment-bot-dev commented Apr 12, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Yared Mekuria and others added 3 commits April 12, 2022 19:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bharathkkb bharathkkb merged commit 8e87308 into terraform-google-modules:master Apr 13, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…ogle-modules#1219)

* add variable to use internal ip endpoints when running kubectl commands

* update README.md

* generate modules, docs and trailing whitespace

* rename to just internal_ip

Co-authored-by: Yared Mekuria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants