Add filestore_csi_driver option for safer cluster variants
#1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraseidler
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
Thanks for the PR! 🚀 |
lauraseidler
force-pushed
the
feature/filestore-safer-cluster
branch
from
94f0d50 to
fa38a70
Compare
bharathkkb
approved these changes
Mar 24, 2022
|
Any update on getting this PR merged in? |
|
@bharathkkb any hints on why the check is failing? I don't have access |
|
@lauraseidler Its due to #1197 which is unrelated to this |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…erraform-google-modules#1176) Co-authored-by: Bharath KKB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added in #1166, but not for the safer cluster variants - I felt like it was safe enough to add though. As there's no further provider version bump required, this should hopefully not be another breaking change.