Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explicitly state the IAM role property used for lambda_role #90

Merged
merged 2 commits into from
Dec 24, 2020
Merged

Conversation

githubuser720
Copy link
Contributor

@githubuser720 githubuser720 commented Dec 23, 2020

Description

Minor change to README to indicate the IAM role ARN should be used when using lambda_role

Motivation and Context

Since the only requirement is a string, you could pass the IAM role name, or other string type properties.
The error on apply (ValidationException) isn't inherently descript enough to know exactly what was wrong.

Breaking Changes

none

How Has This Been Tested?

Reviewed Markdown

@antonbabenko
Copy link
Member

Good point! Could you also change the description for the variable inside variables.tf since it is the origin of the content of README.md?

@githubuser720
Copy link
Contributor Author

Added

@antonbabenko antonbabenko merged commit c56f965 into terraform-aws-modules:master Dec 24, 2020
@antonbabenko
Copy link
Member

Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants