Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Updated AWS provider to v4, added ECR repo force_delete argument in docker-build module #337

Merged
merged 8 commits into from
Aug 18, 2022
Merged

feat!: Updated AWS provider to v4, added ECR repo force_delete argument in docker-build module #337

merged 8 commits into from
Aug 18, 2022

Conversation

1Mill
Copy link
Contributor

@1Mill 1Mill commented Aug 7, 2022 •
edited
Loading

Description

Maintain behavior to force delete created aws_ecr_repository even if it contains images.

Motivation and Context

AWS v4.22.0 introduced a breaking change to the behavior of this module.

Previously, aws_ecr_repository resources would always be destroyed, even if they contained images. Now, aws_ecr_repository resources are only destroyed if either (a) the repository is completely empty of images or (b) force_delete is set to true.

This PR sets force_delete to true so that any created aws_ecr_repository resource is always successfully destroyed on terraform destroy to maintain the existing behavior of this module.

Breaking Changes

  • Requires aws >= 4.22.0

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

@1Mill 1Mill changed the title Add ecr_force_delete option feat: Add ecr_force_delete option Aug 7, 2022
@1Mill 1Mill changed the title feat: Add ecr_force_delete option feat: Set ECR force_delete argument to true Aug 8, 2022
@aalloul aalloul mentioned this pull request Aug 9, 2022
Closed
1 task
antonbabenko
antonbabenko requested changes Aug 16, 2022
View reviewed changes
modules/docker-build/main.tf Outdated Show resolved Hide resolved
modules/docker-build/versions.tf Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@1Mill 1Mill requested a review from antonbabenko August 18, 2022 02:02
@antonbabenko antonbabenko changed the title feat: Set ECR force_delete argument to true feat!: Updated AWS provider to v4, added ECR repo force_delete argument in docker-build module Aug 18, 2022
@antonbabenko antonbabenko merged commit 953ccee into terraform-aws-modules:master Aug 18, 2022
@antonbabenko
Copy link
Member

Hi @1Mill ! Thank you for this addition!

antonbabenko pushed a commit that referenced this pull request Aug 18, 2022
@semantic-release-bot
chore(release): version 4.0.0 [skip ci]
bb43127 
## [4.0.0](v3.3.1...v4.0.0) (2022-08-18)

### ⚠ BREAKING CHANGES

* Updated AWS provider to v4, added ECR repo force_delete argument in docker-build module (#337)

### Features

* Updated AWS provider to v4, added ECR repo force_delete argument in docker-build module ([#337](#337)) ([953ccee](953ccee))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@1Mill 1Mill deleted the add-ecr_force_delete branch August 18, 2022 23:20
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1Mill @antonbabenko