-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ECR Lifecycle Policy Option to docker-build module #243
feat: Add ECR Lifecycle Policy Option to docker-build module #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Please fix docs (pre-commit run -a
) to make GH checks green.
Co-authored-by: Anton Babenko <[email protected]>
Co-authored-by: Anton Babenko <[email protected]>
@antonbabenko, I committed your changes about the default |
# [2.29.0](v2.28.0...v2.29.0) (2022-01-05) ### Features * Add ECR Lifecycle Policy Option to docker-build module ([#243](#243)) ([577b077](577b077))
This PR is included in version 2.29.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Let users add ECR lifecycle policy rules to automate the cleaning up of unused images generated by the
docker-build
module.Motivation and Context
I use this module to build and publish many Docker Images to ECR and I want to be able to easily delete unneeded Docker Images. Since this module is the one building and publishing the Docker Images to ECR it seems best to extend the module to also support the JSON ECR lifecycle policy document.
Breaking Changes
This is not a breaking change and is only added non-breaking functionality to the module.
How Has This Been Tested?
examples/*
projects