Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise failure when CodeDeploy deployment fails #225

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

wgiddens
Copy link
Contributor

@wgiddens wgiddens commented Nov 3, 2021

closes /issues/224

When CodeDeploy fails to finish the deployment, Terraform doesn't realize it and keeps processing. This PR makes the Terraform apply fail whenever the code deploy fails.

@antonbabenko antonbabenko merged commit 16e70be into terraform-aws-modules:master Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply completes successfully even though CodeDeploy fails
2 participants