-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow passing build_args for building with docker-build module #217
feat: Allow passing build_args for building with docker-build module #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you also update the code in the examples to show build_args
for real, and run pre-commit run -a
to update the documentation?
Yes, we stuck with terraform-docs 0.13.0 for the time being. Sorry that I didn't make it clear at first. |
@antonbabenko I switched to 0.13.0 and reran |
No problems, push it all with other changes and I will fix the docs. |
Thanks! |
Thanks, @michaelhelmick ! v2.23.0 has been just released. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
The docker provider allows
build_args
nested in thebuild
map of it'sdocker_registry_image
resource.https://registry.terraform.io/providers/kreuzwerker/docker/latest/docs/resources/registry_image#nested-schema-for-build
I've found use case to pass build args via Terraform to build a docker image.
Motivation and Context
Working a project that needs
build_args
passed and think this is a great addition for anybody to use.Breaking Changes
None.
How Has This Been Tested?
examples/*
projectsI pushed a docker image to an ECR registry via Terraform using my branch as a source. I passed
build_args
in the implementation and in the Dockerfile addedARG TESTING_ARGS
and set it toENV TESTING_ARGS $TESTING_ARGS
and in the DockerfileRUN echo $TESTING_ARGS
That showed the following output after I pulled it, ran it and did a
docker history