Handlers in proxy routes miss context parameter

[yutianwu]

Routes of proxy in lite pkg:

tendermint/lite/proxy/proxy.go

Lines 61 to 86 in 86cf8ee

	func RPCRoutes(c rpcclient.Client) map[string]*rpcserver.RPCFunc {
	return map[string]*rpcserver.RPCFunc{
	// Subscribe/unsubscribe are reserved for websocket events.
	"subscribe": rpcserver.NewWSRPCFunc(c.(Wrapper).SubscribeWS, "query"),
	"unsubscribe": rpcserver.NewWSRPCFunc(c.(Wrapper).UnsubscribeWS, "query"),
	"unsubscribe_all": rpcserver.NewWSRPCFunc(c.(Wrapper).UnsubscribeAllWS, ""),
	// info API
	"status": rpcserver.NewRPCFunc(c.Status, ""),
	"blockchain": rpcserver.NewRPCFunc(c.BlockchainInfo, "minHeight,maxHeight"),
	"genesis": rpcserver.NewRPCFunc(c.Genesis, ""),
	"block": rpcserver.NewRPCFunc(c.Block, "height"),
	"commit": rpcserver.NewRPCFunc(c.Commit, "height"),
	"tx": rpcserver.NewRPCFunc(c.Tx, "hash,prove"),
	"validators": rpcserver.NewRPCFunc(c.Validators, "height"),
	// broadcast API
	"broadcast_tx_commit": rpcserver.NewRPCFunc(c.BroadcastTxCommit, "tx"),
	"broadcast_tx_sync": rpcserver.NewRPCFunc(c.BroadcastTxSync, "tx"),
	"broadcast_tx_async": rpcserver.NewRPCFunc(c.BroadcastTxAsync, "tx"),
	// abci API
	"abci_query": rpcserver.NewRPCFunc(c.ABCIQuery, "path,data"),
	"abci_info": rpcserver.NewRPCFunc(c.ABCIInfo, ""),
	}
	}

actually the handlers need an extra context parameter:

tendermint/rpc/lib/server/handlers.go

Lines 269 to 279 in 86cf8ee

	ctx := &types.Context{HTTPReq: r}
	args := []reflect.Value{reflect.ValueOf(ctx)}
	fnArgs, err := httpParamsToArgs(rpcFunc, cdc, r)
	if err != nil {
	WriteRPCResponseHTTP(w, types.RPCInvalidParamsError(types.JSONRPCStringID(""), errors.Wrap(err, "error converting http params to arguments")))
	return
	}
	args = append(args, fnArgs...)
	returns := rpcFunc.f.Call(args)

so, if we call method in proxy, it will panic and it will complain that we call the func with too many parameters.