Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: log 'Send failed' on Debug #2857

Merged
merged 2 commits into from
Nov 16, 2018
Merged

p2p: log 'Send failed' on Debug #2857

merged 2 commits into from
Nov 16, 2018

Conversation

ebuchman
Copy link
Contributor

Addresses #1817

It's the responsibility of callers to check if the send failed and act appropriately.

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@ebuchman ebuchman requested review from melekes and xla as code owners November 15, 2018 23:17
melekes
melekes approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@melekes melekes merged commit d8ab850 into develop Nov 16, 2018
@melekes melekes deleted the bucky/send-failed branch November 16, 2018 07:38
@ebuchman ebuchman mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@xla xla Awaiting requested review from xla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebuchman @melekes