Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TAC and private policy URLs #1142

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Update TAC and private policy URLs #1142

merged 1 commit into from
Dec 17, 2024
+8 −7

Conversation

NicolasBuquet
Copy link
Contributor

@NicolasBuquet NicolasBuquet commented Dec 16, 2024 •
edited
Loading

@NicolasBuquet NicolasBuquet linked an issue Dec 16, 2024 that may be closed by this pull request
Update TAC and private policy URLs #1141
Closed
@gitguardian GitGuardian
Copy link

gitguardian bot commented Dec 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14813093 Triggered Generic High Entropy Secret 995846d Tchap/Config/BuildSettings.swift View secret
13361669 Triggered Generic High Entropy Secret 995846d Tchap/Config/BuildSettings.swift View secret
🛠 Guidelines to remediate hardcoded secrets

  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

yostyle
yostyle approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasBuquet NicolasBuquet merged commit 985d729 into develop Dec 17, 2024
1 of 7 checks passed
@NicolasBuquet NicolasBuquet deleted the 1141-update-tac-and-private-policy-urls branch December 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TAC and private policy URLs
2 participants
@NicolasBuquet @yostyle