Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DifferencePlainDateTimeWithRounding + DifferenceZonedDateTimeWithRounding: Align argument order for "resolvedOptions" #2877

Closed
anba opened this issue Jun 3, 2024 · 2 comments
Closed

DifferencePlainDateTimeWithRounding + DifferenceZonedDateTimeWithRounding: Align argument order for "resolvedOptions" #2877

anba opened this issue Jun 3, 2024 · 2 comments

Comments

@anba
Copy link
Contributor

anba commented Jun 3, 2024

DifferencePlainDateTimeWithRounding has resolvedOptions as the last argument, but DifferenceZonedDateTimeWithRounding has resolvedOptions in the middle of its arguments. Maybe align DifferenceZonedDateTimeWithRounding with DifferencePlainDateTimeWithRounding?
@ptomato
Copy link
Collaborator

ptomato commented Jun 5, 2024

I'd like to revisit this after it's clear whether there's agreement to remove custom calendars. If there are no user hooks, we don't need to pass an options object to these operations at all.

@ptomato
Copy link
Collaborator

ptomato commented Sep 9, 2024

Obsoleted by #2925.

@ptomato ptomato closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba