You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would rename option to something like optionsOrStep.
I don't like that ifIncrease is shadowed. It looks like you can just get rid of the outer binding.
Why can't you just inline CreateNumericRangeIterator into Iterator.range? I don't see any reason to do a type test, branch, and then completely defer to an AO.
CreateNumericRangeIterator doesn't seem to have its return type declared.
I don't think you need to introduce "NumericRangeIterator Object". What's the purpose?
"NOTE: Prevent value overflow." should be its own step, referring to the next/previous step, and include more explanation.
Use ecmarkup's --lint-spec and --strict options to catch some of these for you. Make sure you update to the latest version.
The text was updated successfully, but these errors were encountered:
Why can't you just inline CreateNumericRangeIterator into Iterator.range? I don't see any reason to do a type test, branch, and then completely defer to an AO.
I don't think you need to introduce "NumericRangeIterator Object". What's the purpose?
I introduce NumericRangeIterator because I expect there will be more types of range in the future, for example, Temporal/Date range and I hope they'll have different object types.
n
. 0nℤ should just be 0ℤ.option
to something likeoptionsOrStep
.ifIncrease
is shadowed. It looks like you can just get rid of the outer binding.CreateNumericRangeIterator
intoIterator.range
? I don't see any reason to do a type test, branch, and then completely defer to an AO.CreateNumericRangeIterator
doesn't seem to have its return type declared.Use ecmarkup's
--lint-spec
and--strict
options to catch some of these for you. Make sure you update to the latest version.The text was updated successfully, but these errors were encountered: