Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [[Construct]] and exoticness from wrapped async functions #36

Closed
littledan opened this issue Mar 15, 2023 · 1 comment · Fixed by #55
Closed

Remove [[Construct]] and exoticness from wrapped async functions #36

littledan opened this issue Mar 15, 2023 · 1 comment · Fixed by #55

Comments

@littledan
Copy link
Member

I don't think the [[Construct]] behavior of .wrap's output is particularly useful; I'd prefer we prioritize simplicity over copying everything that .bind does. Let's have .wrap output an ordinary function instead of some exotic object kind, again for simplicity. This can be done with CreateBuiltinFunction.

@legendecas
Copy link
Member

This can be addressed in #55 as it removes the HOF with AsyncSnapshot. AsyncSnapshot.prototype.run and AsyncLocal.prototype.run merely call the given function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants