Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Quick follow-ups to recent merges #3031

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Editorial: Quick follow-ups to recent merges #3031

merged 2 commits into from
Mar 21, 2023

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Mar 18, 2023

No description provided.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 20, 2023
jmdyck added 2 commits March 21, 2023 15:04
@jmdyck @ljharb
Editorial: Re-word a TypedArray table lookup (tc39#3031)
eb16aed 
During review of PR tc39#2997, @michaelficarra suggested changing:
> the intrinsic object listed in column one of {Table 68} for _exemplar_.[[TypedArrayName]]
to:
> the intrinsic object associated with the constructor name _exemplar_.[[TypedArrayName]] in {Table 68}
in the new AO TypedArrayCreateSameType.
(tc39#2997 (review))

This commit makes the same change in the pre-existing AO TypedArraySpeciesCreate.
@jmdyck @ljharb
Editorial: Mark another step as a Note (tc39#3031)
1dd4ac8 
PR tc39#3026 converted the step:
> Once a generator enters the ~completed~ state it never leaves it and its associated execution context is never resumed. Any execution state associated with _acGenerator_ can be discarded at this point.
in GeneratorStart into a Note.

This commit converts the similar step in GeneratorResumeAbrupt into a Note too.
@ljharb ljharb merged commit 1dd4ac8 into tc39:main Mar 21, 2023
@jmdyck jmdyck deleted the quick_fixes_5 branch March 22, 2023 00:29
@jmdyck jmdyck mentioned this pull request Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdyck @syg @michaelficarra @ljharb