Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: "must be true so, let" should be "must be true, so let" #389

Closed
domenic opened this issue Feb 12, 2016 · 4 comments
Closed

Typo: "must be true so, let" should be "must be true, so let" #389

domenic opened this issue Feb 12, 2016 · 4 comments

Comments

@domenic
Copy link
Member

domenic commented Feb 12, 2016

Otherwise, IsAccessorDescriptor(desc) must be true so, let getter be desc.[[Get]].

@ljharb
Copy link
Member

ljharb commented Feb 12, 2016

I'd go with "must be true, so, let" since the "let …" is a separately emphasized clause ¯_(ツ)_/¯ 🚲🏠

@zenparsing
Copy link
Member

Or use assert. So many choices!

@annevk
Copy link
Member

annevk commented Feb 23, 2016

In HTML we went with "must be true, so let". Happy to provide a PR for ECMAScript if someone wants to call it.

@bterlson
Copy link
Member

Let's just use assert rather than normalizing another convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants