Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint yaml #166

Merged
merged 3 commits into from
Mar 17, 2018
Merged

Lint yaml #166

merged 3 commits into from
Mar 17, 2018

Conversation

waghanza
Copy link
Collaborator

Hi,

I can see that actual neph config file is badly designed

  • line length is huge
  • some keys are duplicated
  • indentation is not strict

Regards,

PS : @tbrand To help in maintaining we can enable Require status checks to pass before merging on master

@waghanza waghanza requested a review from tbrand March 15, 2018 11:51
tbrand
tbrand approved these changes Mar 17, 2018
View reviewed changes
Copy link
Collaborator

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!! 👍

@tbrand tbrand merged commit 1a541fa into the-benchmarker:master Mar 17, 2018
waghanza pushed a commit that referenced this pull request Apr 28, 2018
@tbrand @waghanza
Dockerify2 (#187)
1a93e5b 
* use docker to isolate hosts

* run flask on gunicorn (temporary solution)

* build on ci (only to ensure build could run)

* fix style (underscore for large numbers)

* use shards to release all binaries (client,benchmarker)

* remove unused directory

* uniformize rubies dockerfile

* enable to specify (or not) frameworks to benchmark

* fix style (underscore for large numbers)

* allow docker host

* re-enable django (in a container)

* enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux

* dockerize iris

* fix jester containerization

* re-enable rack-routing

* re-enable lucky

* re-enable amber

* re-enable spider-gazelle

* Lint yaml (#166)

* lint neph config file

* lint actual config file

* disable line length verification (temporary)

* re-enable vapor

* use docker to isolate hosts

* fix style (underscore for large numbers)

* use shards to release all binaries (client,benchmarker)

* enable to specify (or not) frameworks to benchmark

* enable to specify (or not) frameworks to benchmark

* re-enable django (in a container)

* enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux

* re-enable actix

* update dependencies

* fix actix availability

* re-enable rust frameworks
> iron
> nickel
> rocket

* upgrade dependencies

* fix listening ip

* upgrade dependencies

* use rust nightly to cimple rocket

* force shards to install ameba binary

* keep crystal code / yaml files clean

* use production mode

* lint

* fix assets compilation

* use --no-debug flag on compilation

* fix version

* fix version

* remove unnecessary code on lucky

* use production env mode on lucky

* fix nickel running into dockerf

* fix mofuw in docker

* re-enable japronto

* re-enable sanic

* re-enable tornado

* re-enable node frameworks (polka / express)

* remove Package.pins (see #172)

* update to last major

* re-enable swift frameworks (kitura / perfect / vapor)

* re-enable tornado & sanic

* install neph cli tool on compilation

* re-enable elixir frameworks (plug & elixir)

* re-enable libevhtp

* fix version conflict on amber compilation

* add scala framework (akkahttp)

* re-enable mofuw

* re-enable c# (.net) framework

* fix travis config (duplicate key)

* upgrade docker image

* restore evhtp source files

* do not start containers with neph, but on-the-fly

* re-enable node frameworks

* Revert "upgrade docker image"

This reverts commit ba53886.

Since docker image was updated

@see #180 (comment)

* increase sleeping time to wait container starting

* fix aspnetcore container

* use make to build containers sequentially

* crystal tools are compiled with shards intsead of make

* fix

* avoid using lock files

* fix rocket build (needs nighlty)

* fix lucky build
waghanza pushed a commit to AlexWayfer/which_is_the_fastest that referenced this pull request May 3, 2018
@tbrand
Dockerify2 (the-benchmarker#187)
8b0b35d 
* use docker to isolate hosts

* run flask on gunicorn (temporary solution)

* build on ci (only to ensure build could run)

* fix style (underscore for large numbers)

* use shards to release all binaries (client,benchmarker)

* remove unused directory

* uniformize rubies dockerfile

* enable to specify (or not) frameworks to benchmark

* fix style (underscore for large numbers)

* allow docker host

* re-enable django (in a container)

* enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux

* dockerize iris

* fix jester containerization

* re-enable rack-routing

* re-enable lucky

* re-enable amber

* re-enable spider-gazelle

* Lint yaml (the-benchmarker#166)

* lint neph config file

* lint actual config file

* disable line length verification (temporary)

* re-enable vapor

* use docker to isolate hosts

* fix style (underscore for large numbers)

* use shards to release all binaries (client,benchmarker)

* enable to specify (or not) frameworks to benchmark

* enable to specify (or not) frameworks to benchmark

* re-enable django (in a container)

* enable go frameworks -> iris / gin / echo / fasthttprouter / gorilla-mux

* re-enable actix

* update dependencies

* fix actix availability

* re-enable rust frameworks
> iron
> nickel
> rocket

* upgrade dependencies

* fix listening ip

* upgrade dependencies

* use rust nightly to cimple rocket

* force shards to install ameba binary

* keep crystal code / yaml files clean

* use production mode

* lint

* fix assets compilation

* use --no-debug flag on compilation

* fix version

* fix version

* remove unnecessary code on lucky

* use production env mode on lucky

* fix nickel running into dockerf

* fix mofuw in docker

* re-enable japronto

* re-enable sanic

* re-enable tornado

* re-enable node frameworks (polka / express)

* remove Package.pins (see the-benchmarker#172)

* update to last major

* re-enable swift frameworks (kitura / perfect / vapor)

* re-enable tornado & sanic

* install neph cli tool on compilation

* re-enable elixir frameworks (plug & elixir)

* re-enable libevhtp

* fix version conflict on amber compilation

* add scala framework (akkahttp)

* re-enable mofuw

* re-enable c# (.net) framework

* fix travis config (duplicate key)

* upgrade docker image

* restore evhtp source files

* do not start containers with neph, but on-the-fly

* re-enable node frameworks

* Revert "upgrade docker image"

This reverts commit ba53886.

Since docker image was updated

@see the-benchmarker#180 (comment)

* increase sleeping time to wait container starting

* fix aspnetcore container

* use make to build containers sequentially

* crystal tools are compiled with shards intsead of make

* fix

* avoid using lock files

* fix rocket build (needs nighlty)

* fix lucky build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrand tbrand tbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waghanza @tbrand