Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable lucky #116

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Re-enable lucky #116

merged 2 commits into from
Feb 15, 2018

Conversation

waghanza
Copy link
Collaborator

Hi,

Lucky could not compile due to non existant manifest.

The manifest file list static assets.

Regards,

PS : I added an empty one

@waghanza waghanza mentioned this pull request Feb 14, 2018
Closed
tbrand
tbrand approved these changes Feb 15, 2018
View reviewed changes
Copy link
Collaborator

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!!

@tbrand tbrand merged commit 89b8a37 into the-benchmarker:master Feb 15, 2018
@waghanza waghanza deleted the restore_lucky branch February 15, 2018 15:29
@waghanza waghanza restored the restore_lucky branch February 15, 2018 15:50
@waghanza
Copy link
Collaborator Author

waghanza commented Feb 15, 2018 •
edited
Loading

oops, seems this PR was early merged ;-)

I have not seen that dependencies are a little bit outdated , #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrand tbrand tbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waghanza @tbrand