Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update android project to gradle 8 #153

Merged
merged 5 commits into from
May 7, 2023
Merged

feat: update android project to gradle 8 #153

merged 5 commits into from
May 7, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented May 2, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@amrbashir amrbashir marked this pull request as draft May 2, 2023 12:00
@amrbashir amrbashir marked this pull request as ready for review May 2, 2023 13:31
@amrbashir amrbashir mentioned this pull request May 2, 2023
Closed
@amrbashir amrbashir marked this pull request as draft May 2, 2023 17:55
@amrbashir amrbashir marked this pull request as ready for review May 2, 2023 19:51
@wusyong
Copy link
Member

wusyong commented May 4, 2023

@dklassic Could you test if this works for you when you have some time?
We'll worry about if we want to remove buildVariants afterwards.
Related talk is in discord channel:
https://discord.com/channels/616186924390023171/807549941936816148/1102953540084846662

dklassic
dklassic approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@dklassic dklassic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

Tried testing it out with Windows:

  • Build cargo, success
  • Init new project then perform cargo android run, which successfully build the project and stream installed onto test device which then executed successfully

@amrbashir amrbashir requested a review from wusyong May 6, 2023 23:01
@wusyong wusyong merged commit 1245540 into dev May 7, 2023
@wusyong wusyong deleted the feat/gradle-8 branch May 7, 2023 09:48
@github-actions github-actions bot mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklassic dklassic dklassic approved these changes

@wusyong wusyong wusyong approved these changes

Assignees

@dklassic dklassic

Labels
None yet
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @wusyong @dklassic