Hotfix for bug introduced in pr 537 #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally introduced a bug in this morning's merged PR #537
Took a statement out of an if statement in
settings.ts
, which may cause some users to be unable to load ChatCraft.The users that are affected are users who have not logged into ChatCraft since last month.
They have a
settings
JSON in their localStorage, but do not havesettings.currentProvider
. (Because the last time they logged in was last month, back before I introducedsettings.currentProvider
)Also if a user went to localStorage and manually set settings to {}, they would also be affected.
The code from PR 537 which caused the bug:
Fix
Restoring the if statement in this hotfix fixes the issue.
How to test: