Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH CheckPeriod does not accept "always" #128

Open
phinze opened this issue Dec 4, 2024 · 1 comment
Open

SSH CheckPeriod does not accept "always" #128

phinze opened this issue Dec 4, 2024 · 1 comment

Comments

@phinze
Copy link

phinze commented Dec 4, 2024

Tailscale SSH defines the checkPeriod ACL field as either a duration or the string "always".

In our client we are defining the field as just a Duration.

CheckPeriod Duration `json:"checkPeriod,omitempty" hujson:"CheckPeriod,omitempty"`

CheckPeriod Duration `json:"checkPeriod,omitempty" hujson:"CheckPeriod,omitempty"`

This means that we fail to parse policy files that set checkPeriod to "always" with an error like:

time: invalid duration "always"
@bradfitz
Copy link
Member

bradfitz commented Dec 5, 2024

I'd probably just document that negative means always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants