Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure] - Make iOS tests use selection heuristics #2470

Open
angelosilvestre opened this issue Dec 20, 2024 · 1 comment
Open

[Infrastructure] - Make iOS tests use selection heuristics #2470

angelosilvestre opened this issue Dec 20, 2024 · 1 comment
Labels
type_bug Something isn't working

Comments

@angelosilvestre
Copy link
Collaborator

On iOS, we have some selection heuristics to place the caret at word boundaries when tapping at the middle of a word. However, on tests this is disabled by default with the following comment:

// By default we don't use iOS-style selection heuristics in tests because in tests
// we want to know exactly where we're placing the caret.

While this makes sense for some tests, tests that care about interacting with the caret should use these heuristics. One example is #2152, where we have a test to make sure the toolbar is displayed when tapping on the caret, but the test didn't catch the bug because it wasn't using the selection heuristics.

We should modify tests that tap on the caret to use the iOS selection heuristics by default.

@angelosilvestre angelosilvestre added the type_bug Something isn't working label Dec 20, 2024
@angelosilvestre
Copy link
Collaborator Author

cc @matthew-carroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant