Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build may be broken in 6.5.2 #352

Closed
sgrimard opened this issue Sep 12, 2019 · 2 comments · Fixed by #373
Closed

Build may be broken in 6.5.2 #352

sgrimard opened this issue Sep 12, 2019 · 2 comments · Fixed by #373

Comments

@sgrimard
Copy link

Greetings,

It seems the build does not work anymore in 6.5.2. If I am not mistaken, the problem might go back to commit 4781828 and the migration to webpack 4 and as such be present since 6.3.2 (i did not do a bissect to confirm it)

The problem shows up when doing a clean rebuild (right after checkout or after a git clean).
The files in the umd directory that were once generated during build are not output anymore and are instead used as source in the webpack step.

Steps to reproduce:

  • do a clean checkout of the repository
  • yarn install
  • yarn build

Can you confirm this behavior or is something wrong on my end ?

@eordano
Copy link

eordano commented Oct 14, 2019

Confirmed on MacOS Catalina.

@supasate
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants