Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborators #107

Closed
necolas opened this issue Sep 8, 2015 · 21 comments
Closed

Collaborators #107

necolas opened this issue Sep 8, 2015 · 21 comments

Comments

@necolas
Copy link
Contributor

necolas commented Sep 8, 2015

I'm interested in adding collaborators to the project. People who have used it in their apps, and helped others, fixed bugs, etc. cc @simonsmith @giuseppeg

@timkelty
Copy link
Member

timkelty commented Sep 8, 2015

I'd love to help out.

@oleersoy
Copy link
Contributor

oleersoy commented Sep 8, 2015

Same here

@florianbouvot
Copy link

I'm interested too.
I usually work with SUITCSS or INUITCSS...

@giuseppeg
Copy link
Member

@necolas count on me :) Afaik people at Stripe and Segment use SUIT too

@necolas
Copy link
Contributor Author

necolas commented Sep 8, 2015

Thanks! I've added @timkelty and @giuseppeg so far.

@florianbouvot and @oleersoy thanks for your offers of help, Tim and Giuseppe should be able to help review and merge any patches you contribute. We can add you as collaborators once a few patches have been merged.

@simonsmith
Copy link
Member

I'm still using SUIT and watching the main repo, count me in

@necolas
Copy link
Contributor Author

necolas commented Sep 8, 2015

Great! Please all of you feel free to address issues (which you've all been doing anyway, thanks :)), manage pull requests, make changes together.

@oleersoy
Copy link
Contributor

oleersoy commented Sep 8, 2015

Cool - I was a little worried the project was going away :)

@necolas
Copy link
Contributor Author

necolas commented Sep 8, 2015

Sorry about that. I've been preoccupied with a few things at Twitter and testing out React-based approaches like https://github.com/necolas/react-native-web. I should have added collaborators sooner, so thanks for still being open to contributing.

@simonsmith
Copy link
Member

@necolas So have you migrated away from SUIT on newer projects at Twitter. Are you finding that use of React (with inline styles) is negating your need for stricter conventions around naming etc?

@necolas
Copy link
Contributor Author

necolas commented Sep 8, 2015

SUIT methodology is still what new projects are using (including React apps like Periscope). Not all projects are using the tooling to enforce it at the CSS level. Here are some recent projects that use SUIT now.

SUIT has worked out well for them from what I've heard, especially for Cards and Twitter for Websites since Embedded Tweets needs to display Cards (which are rendered by a different service).

I'm working on a React app that doesn't need SUIT because our build step ensures that the class names are local to a component by default, and obfuscated (hashed). I'm also interested in exploring longer-term strategies that avoid direct CSS authoring, and limit the absolute size of the CSS an app depends on.

@simonsmith
Copy link
Member

Interesting. I'd enjoy a blog post on your findings one day I'm sure.

I'm still finding that SUIT works very well on sites that want to take a component based approach but lack something like React and the tooling around it to enforce it. It's also nice to hand other devs the docs and get everyone on the same page. The css-modules project also seems interesting and sounds like it shares the same approach with obfuscated class names.

In terms of tasks with this project - how about moving the SUIT preprocessor to PostCSS and removing the use of Rework? My only thought against that is the fact it isn't hard to replicate with a handful of PostCSS plugins. Be good to get suggestions/opinions

@giuseppeg
Copy link
Member

@simonsmith that's the plan I guess

@simonsmith
Copy link
Member

Ha, okay I didn't see that :)

@necolas
Copy link
Contributor Author

necolas commented Sep 8, 2015

Yeah that sounds good to me

@oleersoy
Copy link
Contributor

oleersoy commented Sep 8, 2015

Thumbs up to the removing rework suggestion. Relying on it can lead to subtle issues that can easily go unnoticed like this one:
h5bp/html5boilerplate.com#134

@timkelty
Copy link
Member

timkelty commented Sep 9, 2015

I would say refactoring suitcss/preprocessor would be a duplication of efforts, when you could just suggest users to use cssnext + suitcss-conformance.

Personally, I've never even used it, and have have always just rolled my own rework/postcss plugin config. I'm not a huge fan of plugin "packs" like cssnext, so I would also lean towards just providing which postcss plugins were needed.

On the flip side, cssnext is the easiest way to get someone up and running...

@timkelty
Copy link
Member

timkelty commented Sep 9, 2015

If we deprecate the preprocessor entirely, we would probably need to rewrite the tests to build with postcss.

@simonsmith
Copy link
Member

My only reasoning for it was due to all the components and utils depending on it in their relevant npm run build settings. We could come up with an alternative like using postcss-cli

I think cssnext is great, but in reality only a small set of the modules are needed to build the components. I found myself switching to picking the plugins I needed rather than using a load of additional ones

@giuseppeg
Copy link
Member

@timkelty @simonsmith let's move this conversation to suitcss/preprocessor#11 so that people can keep track of it

@simonsmith
Copy link
Member

👍

@necolas necolas closed this as completed Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants