Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Para components should use theme.fontSize.text #1717

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

mitsuruog
Copy link
Contributor

Resolved:

This image shows that I've changed the fontSize.text in the config.

React-Styleguidist-Style-Guide

config

module.exports = {
  theme: {
    fontSize: {
      text: 36,
    },
  },
};

@mitsuruog mitsuruog changed the title Fix Para components should use theme.fontSize.base or theme.fontSize.text Fix Para components should use theme.fontSize.text Nov 18, 2020
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1717 (ce3a17b) into master (3e2ff01) will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/client/rsg-components/Para/ParaRenderer.tsx 100.00% <100.00%> (ø)

@sapegin sapegin merged commit 9c2ca5b into styleguidist:master Nov 24, 2020
@sapegin
Copy link
Member

sapegin commented Nov 24, 2020

Thanks!

@sapegin
Copy link
Member

sapegin commented Nov 24, 2020

Looks like it's breaking the props table, we shouldn't use this large font there:

image

It's even visible on your own screenshot but I've missed it ;-/

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mitsuruog mitsuruog deleted the fix-1661 branch November 25, 2020 01:31
@mitsuruog
Copy link
Contributor Author

Looks like it's breaking the props table, we shouldn't use this large font there:

@sapegin I'll work on that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants