Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI builds for easy testing #6

Open
Calinou opened this issue May 1, 2023 · 9 comments
Open

Add GitHub Actions CI builds for easy testing #6

Calinou opened this issue May 1, 2023 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@Calinou
Copy link

Calinou commented May 1, 2023

Similar to what https://github.com/stuntrally/stuntrally has, we should add CI builds with artifacts so you can test the latest Git version quickly. This is especially important for Linux as OGRE-next and MyGUI-next are now required, neither of which are widely available in Linux distribution repositories. See also #1.

To keep artifacts small, only the Stunt Rally and sr-editor executables should be included (plus any required libraries), not the game data. You'd have to download the game data and tracks as a ZIP separately, then install the executables within the root folder of the extracted game data.

Maybe we can build a Flatpak for Linux too, but separating the game data from binaries will require modifying Stunt Rally so that it can optionally look for game data in a separate folder (since it won't be included in the Flatpak itself in this case).

@cryham
Copy link
Member

cryham commented May 1, 2023

Right. But does #1 already add Actions? I'm not sure what the status is there.

@AnotherFoxGuy
Copy link
Contributor

But does #1 already add Actions?

Yes, that PR adds GitHub Actions, you can a preview of it here: https://github.com/AnotherFoxGuy/stuntrally3/actions
The issue with #1 is that I've been unable to get stuntrally3 to build properly

@cryham
Copy link
Member

cryham commented Oct 2, 2023

Ok @Calinou but how would that ZIP with data be made?
Or shoud it be git pulled by user? Probably there should be a hash of data saying this auto build binary needs repo from this commit to work (was based on it).
Data like materials, Gui layouts and others really need to be the same, not from other version, since at least Gui will crash game if it there isn't a control in .layout but is needed in code.
Anyways I'm okay if we have a 1 to 2GB zip always. Downloads are fast, at least no data will be misplaced or so.

@cryham cryham added the help wanted Extra attention is needed label Oct 5, 2023
@cryham
Copy link
Member

cryham commented Apr 13, 2024

Hi @AnotherFoxGuy
So this is being built okay since a while.
But just recently we tested Windows zip and it does not have RenderSystem_GL3Plus.dll which seems to be the only one working for SR3 now. Do you build it in your package ogre-next, could you add it?
As for Linux there is no zip or other pack. What needs to be done to have it auto made on builds, is it impossible? Looks the same in old SR too.

@Calinou
Copy link
Author

Calinou commented Apr 15, 2024

Anyways I'm okay if we have a 1 to 2GB zip always. Downloads are fast, at least no data will be misplaced or so.

I think this will be the best approach from an UX perspective, but at the same time, remember that GitHub Actions artifact storage is limited to 10 GB in total per repository. If you have large artifacts already uploaded (and not expired yet), you may be prevented from creating builds for every commit (or even daily builds) if you keep the default retention limit of 90 days. You could get around this by reducing the artifact retention limit in the repository settings, and creating builds less often if done on a schedule. Building every 2 days and using a retention limit of 15 days should work within this 10 GB limit.

@cryham
Copy link
Member

cryham commented Apr 15, 2024

Yes space is an issue. I'd love to move to some hosting and not bother if we fit into 2GB limit per release on github or how is it on sourceforge IDK. But hosting is costly and I'd rather not spend time moving all, unless necessary.
Just FYI, CI builds are small here 15MB (only Windows) and only have binaries. So it's not an issue. But for big releases it could be soon.

@cryham
Copy link
Member

cryham commented May 10, 2024

Something got broken recently. Both builds are failing. @AnotherFoxGuy could you please look into it?

@AnotherFoxGuy
Copy link
Contributor

@cryham The licence file got deleted: 63441f1
That file is used for the cpack installers

@cryham
Copy link
Member

cryham commented May 11, 2024

Ah thanks, I didn't realize. Changed to License.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants