Skip to content
This repository has been archived by the owner on Apr 18, 2020. It is now read-only.

Refactor user to another name #73

Open
superkhau opened this issue Mar 1, 2016 · 10 comments
Open

Refactor user to another name #73

superkhau opened this issue Mar 1, 2016 · 10 comments

Comments

@superkhau
Copy link
Contributor

We get a lot of confusion from my original implementation of user extending builtin User. We should rename it to something like CustomUser or something to signify it's obviously not the same as builtin User.

@timotheemoulin
Copy link

Thanks for reporting that ;)

The official documentation tells us to use Customer or Client when overriding the User model.
Moreover, I am not conviced that mixing naming conventions in the example is a good practice.

https://docs.strongloop.com/display/public/LB/Managing+users

@superkhau
Copy link
Contributor Author

Do you have any suggestions? 👂

@timotheemoulin
Copy link

I think that using the same names as in the official documentation Customer, Client would be a good idea. I might highy help people understanding the examples.

@superkhau
Copy link
Contributor Author

Haha, actually user was the official name before and we added Customer/Client because we had to keep explaining it before, but never got around to updating the examples to match. ;) I think we'll go with Customer because Client will probably cause other issues down the line. Thanks for the feedback.

@timotheemoulin
Copy link

Ok I get it.

I don't mind using User twice. That's even what I would have done if
not told otherwise in the doc. What bother me more is that it's once
written in lowercase and the second time with an uppercase U

@superkhau
Copy link
Contributor Author

No, it has to be lowercase or it will conflict with the builtin User model. That or you can name it something other than "User".

@DaGaMs
Copy link

DaGaMs commented May 3, 2016

the User vs user issue also breaks down if you use mysql as a backend, since it can't distinguish between tables by case.

@antarasi
Copy link

Account seems to be distinguishable enough and independent from actual user purpose (Client, Customer etc)

@superkhau
Copy link
Contributor Author

Would someone like to submit a PR? I can help with the landing. ;)

@csakis
Copy link
Contributor

csakis commented Dec 19, 2017

I addressed this issue in a new PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants