Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider a better default config file for your container. #705

Open
SleepyBrett opened this issue Mar 6, 2019 · 2 comments
Open

Consider a better default config file for your container. #705

SleepyBrett opened this issue Mar 6, 2019 · 2 comments

Comments

@SleepyBrett
Copy link

I recently did an upgrade from a fairly old version of the tool (4.x) to 11.x and found that with the inclusion and default use of your default config file my deployment went from working to spewing errors right and left.

It's my opinion that all sinks should probably have an enabled true/false flag but also maybe not providing values that cause them to activate by default would be nice. A short list of things I can remember modifying the config file to disable, splunk, falconer, signalfx, gprc, xray...
@daviddyball
Copy link

I also just came across this issue. I wanted only the SignalFX sink, but because the default config ships with a DataDog API Key set (to fart) it started crash-looping because it couldn't auth with DataDog correctly.

Does setting the env-var VENEUR_DATADOGAPIKEY to "" work at disabling the sink?

@daviddyball
Copy link

Raised a PR with no sinks enabled by default: #733

@daviddyball daviddyball mentioned this issue Jun 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Sane Docker Default Config
2 participants
@SleepyBrett @daviddyball