Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shouldUpdateTopicInKafkaWhen* test flakiness #10921

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fvaleri
Copy link
Contributor

@fvaleri fvaleri commented Dec 6, 2024

Type of change

  • Bugfix

Description

Attempt to fix shouldUpdateTopicInKafkaWhen* test flakiness.
We cannot reproduce locally, so I would need to use some CI time to verify.

Checklist

  • Make sure all tests pass

@fvaleri fvaleri marked this pull request as draft December 6, 2024 14:45
@ppatierno ppatierno added this to the 0.46.0 milestone Dec 6, 2024
@fvaleri fvaleri force-pushed the to-flaky-its branch 6 times, most recently from aa6135f to 9d68abc Compare December 7, 2024 17:18
@fvaleri
Copy link
Contributor Author

fvaleri commented Dec 8, 2024

@see-quick I ran the CI for 10 times without issues. Can you also check and confirm? Thanks.

@see-quick
Copy link
Member

@see-quick I ran the CI for 10 times without issues. Can you also check and confirm? Thanks.

I will take a look at this tomorrow. Thanks

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Federico Valeri <[email protected]>
@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member

/azp run build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fvaleri
Copy link
Contributor Author

fvaleri commented Dec 12, 2024

This is unrelated to previous test failures and new:

2024-12-12T15:18:58.6368702Z [ERROR] io.strimzi.operator.topic.KafkaHandlerIT.shouldDescribeTopics -- Time elapsed: 9.002 s <<< ERROR!
2024-12-12T15:18:58.6369340Z java.util.NoSuchElementException: No value present
2024-12-12T15:18:58.6369827Z 	at java.base/java.util.Optional.get(Optional.java:143)
2024-12-12T15:18:58.6370319Z 	at io.strimzi.operator.topic.KafkaHandlerIT.shouldDescribeTopics(KafkaHandlerIT.java:246)

Here we fixed an ordering issue, and that's fine. But I don't understand why changeTopic and describeTopic are sometimes not executed.

I think we need to enable trace level and maybe add some more logging. I also wonder if testcontainers could be somewhat responsible. Does it run differently on Azure compared to dev machines? @see-quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants