Annotate StrimziPodSets before rolling during CA renewal #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes strimzi#10710 Signed-off-by: Katherine Stanley <[email protected]>
scholzj
reviewed
Oct 15, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/WorkloadUtils.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/WorkloadUtils.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/CaReconciler.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/CaReconciler.java
Outdated
Show resolved
Hide resolved
...r-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/CaReconcilerTest.java
Outdated
Show resolved
Hide resolved
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Oct 15, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/operator/assembly/CaReconciler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Katherine Stanley <[email protected]>
scholzj
approved these changes
Oct 16, 2024
| .flatMap(podSet -> ReconcilerUtils.nodesFromPodSet(podSet).stream()) | ||
| .collect(Collectors.toSet())); | ||
| } else { | ||
| return Future.succeededFuture(new LinkedHashSet<>()); |
There was a problem hiding this comment.
This could be just Set.of(), or? Or is something added to it later? I don't think so.
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Katherine Stanley <[email protected]>
|
@katheris there seems to be checkstyle errors to be fixed. |
Signed-off-by: Katherine Stanley <[email protected]>
|
/azp run zookeeper-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks for the PR. |
8 tasks
scholzj
added a commit
that referenced
this pull request
Oct 25, 2024
)" This reverts commit dcaa5e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
Update the CaReconciler to annotate the StrimziPodSets with the new CA cert generations before it rolls the Kafka nodes.
Checklist
Please go through this checklist and make sure all applicable tasks have been done