Add support for Secret or ConfigMap based environment variables in ContainerTemplate
#10623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
changed the title
CotnainerTemplateContainerTemplate
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…tnainerTemplate Signed-off-by: Jakub Scholz <[email protected]>
scholzj
force-pushed
the
support-for-secret-and-cm-based-env-vars
branch
from
c5cbfb2 to
df74a2d
Compare
PaulRMellor
approved these changes
Sep 23, 2024
api/src/main/java/io/strimzi/api/kafka/model/common/ContainerEnvVar.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/connect/ExternalConfiguration.java
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-config-kafka-connect.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/con-configuration-points-configmaps.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <[email protected]>
katheris
approved these changes
Sep 23, 2024
| @@ -49,6 +52,15 @@ public void setValue(String value) { | |||
| this.value = value; | |||
| } | |||
|
|
|||
| @Description("Reference to secret or config map property to which will be the environment variable is set.") | |||
There was a problem hiding this comment.
I see Paul reviewed this before, but it still isn't quite what he proposed and didn't make sense to me, so re-proposing what he suggested.
Suggested change
| @Description("Reference to secret or config map property to which will be the environment variable is set.") | |
| @Description("Reference to the secret or config map property to which the environment variable is set.") |
|
@scholzj I was too slow with my review! |
|
@katheris I will open a separate Pr to fix it. |
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR implements the Strimzi Proposal #85 and adds the possibily to configure Secret or ConfigMap based environment variables in any container through the container template section.
It also deprecates the rest of the
externalConfigurationsection in Connect and MM2 that allowed the same, but only in the Connect and MM2 resources.Checklist