Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keystore/truststore pwd from kafka agent command #10480

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

wangshu3000
Copy link
Contributor

@wangshu3000 wangshu3000 commented Aug 21, 2024

Type of change

  • Refactoring

Description

This PR is to refactor the kafka-agent startup command, move the keystore/truststore related parameters to a properties file, so that they don't show up in the process table.

This is an improvement on issue: #9957

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some comments.

docker-images/kafka-based/kafka/scripts/kafka_run.sh Outdated Show resolved Hide resolved
@scholzj scholzj added this to the 0.44.0 milestone Aug 21, 2024
@scholzj
Copy link
Member

scholzj commented Aug 23, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@scholzj scholzj merged commit 8c525a8 into strimzi:main Aug 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants