Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small followups to recent PRs #192

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Some small followups to recent PRs #192

merged 2 commits into from
Dec 3, 2021

Conversation

garyp
Copy link
Collaborator

@garyp garyp commented Dec 3, 2021

  • Codegen: Suppress more warnings for deprecated fields in generated code
  • Make MessageDescriptor's fullName and name fields public: turns out we already have a use case for this at Streem

seanadkinson
seanadkinson approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@seanadkinson seanadkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@garyp
Make MessageDescriptor's fullName and name fields public
05212bd 
Turns out we already have a use case for this.
@garyp garyp force-pushed the garyp/small-fixups branch from c26ab15 to 05212bd Compare December 3, 2021 22:55
@garyp garyp merged commit 83318d9 into master Dec 3, 2021
@garyp garyp deleted the garyp/small-fixups branch December 3, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanadkinson seanadkinson seanadkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyp @seanadkinson