Refactor handling of special JSON types #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
force-pushed
the
garyp/message-fullname
branch
from
4caab4f to
0a0b10f
Compare
Centralize all handling of protobuf messages that use a custom JSON representation into a new `JsonMessageAdapter` interface. This will make it easier to add types to the future without having to do lots of plumbing for each new type. Note that this only includes protobuf messages that have a custom JSON representation but use the normal generated message in Kotlin. Protobuf messages that also use a custom type in Kotlin (namely, the `*Value` protobuf types that are converted to nullable primitive types in Kotlin) are not currently handled via `JsonMessageAdapter`.
garyp
force-pushed
the
garyp/json-special-types-refactor
branch
from
e47c4c8 to
0a9ebf2
Compare
rahulreddym
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize all handling of protobuf messages that use a custom JSON representation into a new
JsonMessageAdapterinterface. This will make it easier to add types to the future without having to do lots of plumbing for each new type.Note that this only includes protobuf messages that have a custom JSON representation but use the normal generated message in Kotlin. Protobuf messages that also use a custom type in Kotlin (namely, the
*Valueprotobuf types that are converted to nullable primitive types in Kotlin) are not currently handled viaJsonMessageAdapter.