Add proto name and fullName properties to MessageDescriptor #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
force-pushed
the
garyp/message-fullname
branch
from
8402152 to
4caab4f
Compare
…eBuilder This allows Kotlin type name logic to mirror the protobuf type name logic: all type names are part of the type's data that is computed in the `FileBuilder`. The `CodeGenerator` references those names to generate code but no longer contains any logic for figuring out the names.
garyp
force-pushed
the
garyp/message-fullname
branch
from
4caab4f to
0a0b10f
Compare
Base automatically changed from
garyp/suppress-deprecated-warnings
to
master
November 24, 2021 18:04
rahulreddym
reviewed
Nov 29, 2021
rahulreddym
reviewed
Nov 29, 2021
rahulreddym
reviewed
Nov 29, 2021
rahulreddym
reviewed
Nov 29, 2021
rahulreddym
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for another PR that will add support for
Any(see #63). Might be easier to review by looking at the individual commits in this PR rather than the combined diff.